Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Hash-based comparison for weak compare #33

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ltclever
Copy link
Contributor

@ltclever ltclever commented Nov 1, 2016

an attempt to make weak compare faster

a little hacky. to be tested.

@ltclever
Copy link
Contributor Author

ltclever commented Nov 1, 2016

@ltclever
Copy link
Contributor Author

ltclever commented Nov 1, 2016

ran a correctness job with weak compare enabled on permissions service (which sees array reordering)

standard recursive compare (master branch) results:

2016/11/01 20:10:02 Results map[int]map[int]int{},
2016/11/01 20:10:02 0 Diffs using weak compare: true,
{"control_url":"https://ltc--permissions-service.int.clever.com:443",
"deploy_env":"ltc-hs",
"diffs":0,
"exp_url":"https://ltc-exp--permissions-service.int.clever.com:443",
"last_gorfile":"/tmp/prod-replay-testing-permissions-service-1-2016-11-01-17-01-40-56f4d9d8-9654-458f-b178-89ff1c99818a.txt",
"level":"info",
"load_url":"",
"reqs":2122,
"source":"http-science",
"title":"progress"},
2016/11/01 20:10:02 2122 reqs in 35m14.470129024s seconds

@Christopher-Bradshaw
Copy link
Contributor

I've also found running it with some intentional diffs a useful sanity check.

@ltclever ltclever force-pushed the ltc-hash-compare-algorithm branch from 674f6af to 54169e5 Compare November 4, 2016 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants