Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented resending of data when performing a flash in buffered output #407

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

dngrudin
Copy link
Contributor

@dngrudin dngrudin commented Dec 17, 2024

@Enmk These are additional corrections necessary for the correct operation of the changes implemented in the PR #407. Implement resend when performing a flash on a buffered output. Please check.

@CLAassistant
Copy link

CLAassistant commented Dec 17, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@Enmk Enmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can be merged after all tests are passing

@dngrudin
Copy link
Contributor Author

LGTM, can be merged after all tests are passing

@Enmk If there are no more questions for the pull request, can you do the merge?

@Enmk Enmk merged commit 8ad0fd4 into ClickHouse:master Jan 13, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants