Fix scroll position of main content when left sidebar requires scrolling to show active item #3175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing to show active item Also now the search bar is always visible, previously search bar and the first item from the sidebar was hidden after scrolling the main content. Issue with the scroll position can be easily reproduced by navigating "/docs/en/optimize/skipping-indexes"
DamianMaslanka5
force-pushed
the
fix-scroll
branch
from
d851729 to
65fe444
Compare
DamianMaslanka5
changed the title
|
@gingerwizard I thinks this is ready for a review now, I found some time browse the docs with these changes and didn't see any issues. |
Blargian
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Try to fix scroll position of main content when left sidebar requires scrolling to show active item
Also now the search bar is always visible, previously search bar and the first item from the sidebar was hidden after scrolling the main content.
You can see both issues on https://clickhouse.com/docs/en/optimize/skipping-indexes
I made minimum amount of changes which fixed described issues.
I tested:
Before
before.mp4
After
after.mp4