Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the UID column a string #11

Merged
merged 1 commit into from
May 30, 2024
Merged

make the UID column a string #11

merged 1 commit into from
May 30, 2024

Conversation

tommyzli
Copy link
Collaborator

the uid type in kubernetes is just an alias to the string type and makes no restrictions about the structure of the uid. While all k8s controllers set proper uuids, there are other components like some EKS controllers that don't

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@tommyzli tommyzli merged commit e830baa into master May 30, 2024
2 checks passed
@tommyzli tommyzli deleted the uid-string branch May 30, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants