-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spark 3.5: Support micro timestamp #311
Conversation
thanks for making this change, do you have a chance to add a ut? |
@pan3793 let me take a look. By the way, how to build the java tar locally? |
Oh, I forget to update the docs when switching the default Spark version from 3.4 to 3.5, the jar should be at
|
you can skip changes for spark-3.4 and spark-3.3, just focus on clickhouse-core and spark-3.5, there is a half-auto script to backport the patch to older spark versions. |
There is no test suite that I can easily extend.... (and I am not familiar with java/scala.. |
Okay~ |
you can construct a simple case and leave it in the comments, I will find time to add it to UT later |
Previous
With this fix
|
can try both |
the default value is "json", if "binary" works too, it's good |
yea I tried both |
Thanks, merged to master |
when will we release? |
Fix #310