Add cloud tests #339
Closed
Add cloud tests #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan3793
reviewed
Jul 15, 2024
spark-3.5/clickhouse-spark/src/main/scala/xenon/clickhouse/ClickHouseCatalog.scala
Outdated
Show resolved
Hide resolved
pan3793
reviewed
Jul 15, 2024
clickhouse-core/src/main/scala/xenon/clickhouse/parse/AstVisitor.scala
Outdated
Show resolved
Hide resolved
pan3793
reviewed
Jul 15, 2024
...e-spark-it/src/test/scala/org/apache/spark/sql/clickhouse/single/ClickHouseSingleSuite.scala
Outdated
Show resolved
Hide resolved
pan3793
reviewed
Jul 15, 2024
| val CLICKHOUSE_VERSION: String = Utils.load("CLICKHOUSE_VERSION", "23.8") | ||
| val isCloud: Boolean = if (CLICKHOUSE_VERSION.equalsIgnoreCase("cloud")) true else false | ||
| val isOnPrem: Boolean = !isCloud | ||
| val CLICKHOUSE_IMAGE: String = if (isCloud) "clickhouse/clickhouse-server:23.8" |
There was a problem hiding this comment.
this is too hacky.
I would suggest adding a new ClickHouseCouldMixIn alongside the existing ClickHouseSingleMixIn and ClickHouseClusterMixIn.
There was a problem hiding this comment.
this comment was ignored. the current change mixes things up. Let me clarify more details
ClickHouse*MixIn tasks responsibility to provide a ClickHouse instance(s) to run integration tests:
ClickHouseSingleMixInprovides a single ClickHouse instance by using docker to launch a single containerClickHouseClusterMixInprovides a ClickHouse cluster by using docker compose to launcher a set of containersClickHouseCouldMixInshould just expose ClickHouse Cloud instance's URL and credential.
There was a problem hiding this comment.
this will introduce some refactoring, i will take a look if i find time this weekend
pan3793
reviewed
Jul 15, 2024
...e-spark-it/src/test/scala/org/apache/spark/sql/clickhouse/single/ClickHouseSingleSuite.scala
Outdated
Show resolved
Hide resolved
clickhouse-core/src/testFixtures/scala/xenon/clickhouse/base/ClickHouseClusterMixIn.scala
Outdated
Show resolved
Hide resolved
spark-3.5/clickhouse-spark-it/src/test/scala/org/apache/spark/sql/clickhouse/SparkTest.scala
Outdated
Show resolved
Hide resolved
BentsiLeviav
approved these changes
Jul 15, 2024
pan3793
requested changes
Jul 15, 2024
clickhouse-core/src/main/scala/xenon/clickhouse/parse/AstVisitor.scala
Outdated
Show resolved
Hide resolved
spark-3.5/clickhouse-spark/src/main/scala/xenon/clickhouse/ClickHouseCatalog.scala
Outdated
Show resolved
Hide resolved
spark-3.5/clickhouse-spark/src/main/scala/xenon/clickhouse/ClickHouseCatalog.scala
Outdated
Show resolved
Hide resolved
| val CLICKHOUSE_VERSION: String = Utils.load("CLICKHOUSE_VERSION", "23.8") | ||
| val isCloud: Boolean = if (CLICKHOUSE_VERSION.equalsIgnoreCase("cloud")) true else false | ||
| val isOnPrem: Boolean = !isCloud | ||
| val CLICKHOUSE_IMAGE: String = if (isCloud) "clickhouse/clickhouse-server:23.8" |
There was a problem hiding this comment.
this comment was ignored. the current change mixes things up. Let me clarify more details
ClickHouse*MixIn tasks responsibility to provide a ClickHouse instance(s) to run integration tests:
ClickHouseSingleMixInprovides a single ClickHouse instance by using docker to launch a single containerClickHouseClusterMixInprovides a ClickHouse cluster by using docker compose to launcher a set of containersClickHouseCouldMixInshould just expose ClickHouse Cloud instance's URL and credential.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add cloud tests
Checklist
Delete items not relevant to your PR: