Test: Refactor tests to support ClickHouse Cloud #347
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan3793
commented
Jul 24, 2024
| scala: [ 2.12, 2.13 ] | ||
| env: | ||
| CLICKHOUSE_CLOUD_HOST: ${{ secrets.INTEGRATIONS_TEAM_TESTS_CLOUD_HOST_SMT }} | ||
| CLICKHOUSE_CLOUD_PASSWORD: ${{ secrets.INTEGRATIONS_TEAM_TESTS_CLOUD_PASSWORD_SMT }} |
There was a problem hiding this comment.
were these secrets set up properly? @mzitnik
pan3793
changed the title
|
I will test your branch locally |
|
I have also noticed that ClickHouseSingle{XXXX} and clickHouseCloud{XXXX} both running with |
mzitnik
requested changes
Jul 28, 2024
|
|
||
| def withNodeClient(protocol: ClickHouseProtocol = HTTP)(block: NodeClient => Unit): Unit = | ||
| Utils.tryWithResource { | ||
| NodeClient(NodeSpec(clickhouseHost, Some(clickhouseHttpPort), Some(clickhouseTcpPort), protocol)) |
There was a problem hiding this comment.
We need to add here in case of cloud username, password, and options with a value of ("ssl", "true")
|
@pan3793 I can pull this branch under ClickHouse/spark-clickhouse-connector and do the needed fixes so we could run it with our cloud credentials |
|
close and in favor #349 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Delete items not relevant to your PR: