Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not parse index sequence #4187

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

islean
Copy link
Contributor

@islean islean commented Feb 7, 2025

Description

We generate the index sequence from the index and index number and do not allow for any deviation from generated one. So we should not parse it from jsons since it will not impact the order either way.

Added

Changed

Fixed

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@islean
Copy link
Contributor Author

islean commented Feb 7, 2025

A bit uncertain if we should remove the validation as well? And make the index sequence a completely internal field on the FluffySample and RMLSample?

@Vince-janv
Copy link
Contributor

A bit uncertain if we should remove the validation as well? And make the index sequence a completely internal field on the FluffySample and RMLSample?

I think we should remove it. It feels weird to validate something that we implicitly have already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants