Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final polish for the highlighting feature #502

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Final polish for the highlighting feature #502

merged 2 commits into from
Nov 16, 2023

Conversation

bglw
Copy link
Contributor

@bglw bglw commented Nov 16, 2023

Follow on from #425

  • Moves logic out of the Default UI and into the underlying JS API
    • Makes it available for users beyond the Default UI, and also fixes some issues with the previous string handling of the URL when combining this feature and subresults, or existing query parameters
  • Changes query parameters to opt-in rather than opt-out to eliminate the breaking change to URLs
  • Adjusts the documentation to match

@bglw bglw merged commit 02d8177 into main Nov 16, 2023
4 checks passed
@bglw bglw mentioned this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant