tcp-chnl: add TCP connection established callback for connect and accept #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit adds calls the TCP connection callback for clients when they establish a connection i.e. the connection is ready to send and receive data. To simplify things, `CHNL_TCP_ACCEPT_TYPE` is renamed to `CHNL_TCP_ESTABLISHED_TYPE`. The callback type is used for both server's `accept` and client's `connect`. In case of accept, the listening channel descriptor is passed to the callback. In case of connect, the client channel descriptor is passed. Signed-off-by: Jalal Mostafa <[email protected]>
maryamtahhan
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CNDP follows an asynchronous pattern. We cannot call some functions before the connection is established e.g.
chnl_send, so we need a notification that the TCP connection has been established.The commit adds calls to the TCP connection callback for clients when they establish a connection i.e. the connection is ready to send and receive data.
To simplify things,
CHNL_TCP_ACCEPT_TYPEis renamed toCHNL_TCP_ESTABLISHED_TYPE. The callback type is used for both the server'sacceptand the client'sconnect. In the case ofaccept, the listening channel descriptor is passed to the callback. In the case ofconnect, the client channel descriptor is passed.