pre-commit: integrate with cndp #373
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryamtahhan
commented
Jun 20, 2024
| @@ -1,5 +1,4 @@ | |||
| API {#index} | |||
| === | |||
| # API {#index} | |||
There was a problem hiding this comment.
Restore this file and add it to the ignore list
maryamtahhan
commented
Jun 20, 2024
maryamtahhan
commented
Jun 20, 2024
lang/rs/wireguard/patch/0002-Remove-LD_PRELOAD-from-cndprustwg-script.patch
Show resolved
Hide resolved
maryamtahhan
commented
Jun 20, 2024
maryamtahhan
commented
Jun 20, 2024
maryamtahhan
commented
Jun 20, 2024
maryamtahhan
force-pushed
the
pre-commit
branch
3 times, most recently
from
455bca3 to
ca2034a
Compare
maryamtahhan
force-pushed
the
pre-commit
branch
7 times, most recently
from
4b16d80 to
5f9f8d5
Compare
|
Sorry for the noise - it took a while to find the right recipe of clang versions between pre-commit hooks and the github action |
|
:) Markdown linter disconnect now :( |
KeithWiles
approved these changes
Jun 20, 2024
|
Should this get merged now or will you be fixing the Lint Code Base issues? |
|
I will fix them :) |
Install pre-commit for CNDP + its configuration. Remove old githook. Signed-off-by: Maryam Tahhan <[email protected]>
|
Linting issues are now fixed. I just rebased there and kicked off the github actions again. As soon as they complete we should be good. Sorry again for all the noise :( I couldn't reproduce the issues locally |
|
Going to close this. Will do some retest and send up a new branch. I have to head away and there's 1 or 2 things I'm not fully happy with - Sorry. |
|
No problem it is a lot of work, Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Install pre-commit for CNDP + its configuration.
Remove old githook.