CLI: create run command
#74
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asimpleidea
force-pushed
the
refactor/create-cli
branch
7 times, most recently
from
e5ec0d4 to
f270eb3
Compare
asimpleidea
force-pushed
the
refactor/create-cli
branch
from
f270eb3 to
1f4929b
Compare
5 tasks
This was referenced Aug 17, 2022
asimpleidea
force-pushed
the
refactor/create-cli
branch
3 times, most recently
from
a41fbc8 to
a30f042
Compare
asimpleidea
force-pushed
the
refactor/create-cli
branch
2 times, most recently
from
17f8b58 to
e62998d
Compare
This commit creates the foundations of the new CLI, introducing the root command and the `run` command. This latter one will be used to to run the program and will have many sub-commands, which will be added in next commits. Signed-off-by: Elis Lulja <[email protected]>
The `run` function executes the program as it used to, but is now oblivious of the service registry you choose. Signed-off-by: Elis Lulja <[email protected]>
This commit moves code to get files from a path or a configmap/secret to separate functions or utility functions.
asimpleidea
force-pushed
the
refactor/create-cli
branch
from
e62998d to
5212ee5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit creates the foundations of the new CLI, introducing the root command and the
runcommand.This latter one will be used to to run the program and will have many sub-commands, which will be added in next commits.
NOTE: this new CLI is not enabled yet, and it will be once all the other sub-commands will be introduced as well.
TODOs:
Runfunction that will run all controllers regardless of the service registryOther TODOs coming as development continues...