Allow empty metadata #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enables the CN-WAN Reader to retrieve all services from Service Directory without specifying a filter. Signed-off-by: Elis Lulja <[email protected]>
This commit allows the CN-WAN Reader to retrieve all services from Cloud Map regardless of the instance attributes. Signed-off-by: Elis Lulja <[email protected]>
Signed-off-by: Elis Lulja <[email protected]>
asimpleidea
force-pushed
the
allow-empty-metadata
branch
from
d833e67 to
81aca8e
Compare
This commit just updates a section of the documentation by specifying the new behavior of --metadata-keys. Signed-off-by: Elis Lulja <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the CN-WAN Operator to get all services, regardless of the metadata/attributes they have.
This solves #33 only partly, as it only allows the reader to ignore metadata and not perform a more sophisticated filtering.
Note that this does not work for AWS Tags yet, as this is based on a older commit. Will push here again once #36 is merged.