Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: userdir: Get the effictive user name instead of using getpass.getuser #1221

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

liangxin1300
Copy link
Collaborator

@liangxin1300 liangxin1300 commented Jul 27, 2023

The return result from getpass.getuser may be incorrect since the function checks system environment variables LOGNAME, USER, LNAME, and USERNAME

@liangxin1300 liangxin1300 changed the title Dev: userdir: Get the effictive user name instead of using getpass.ge… Dev: userdir: Get the effictive user name instead of using getpass.getuser Jul 27, 2023
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #1221 (f8ac614) into master (be00347) will increase coverage by 0.10%.
Report is 8 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1221      +/-   ##
==========================================
+ Coverage   52.38%   52.49%   +0.10%     
==========================================
  Files          78       78              
  Lines       25000    25014      +14     
==========================================
+ Hits        13097    13130      +33     
+ Misses      11903    11884      -19     
Files Changed Coverage Δ
crmsh/userdir.py 79.06% <100.00%> (+1.02%) ⬆️

... and 4 files with indirect coverage changes

…tuser (bsc#1213821)

The return result from getpass.getuser may be incorrect
since the function checks system environment variables LOGNAME, USER, LNAME, and USERNAME
@liangxin1300 liangxin1300 changed the title Dev: userdir: Get the effictive user name instead of using getpass.getuser Fix: userdir: Get the effictive user name instead of using getpass.getuser Aug 1, 2023
@liangxin1300 liangxin1300 merged commit 4a06200 into ClusterLabs:master Aug 1, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants