Fix: upgradeutil: reduce the timeout for getting sequence from remote node (bsc#1213797) #1222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasyang2022
force-pushed
the
upgradeutil_timeout
branch
from
62fdf40
to
548eb4b
Compare
| @@ -137,8 +147,7 @@ def upgrade_if_needed(): | |||
| return | |||
| nodes = crmsh.utils.list_cluster_nodes(no_reg=True) | |||
| if nodes is not None and len(nodes) > 1 \ | |||
| and _is_upgrade_needed(nodes) \ | |||
| and not crmsh.utils.check_passwordless_between_nodes(nodes): | |||
There was a problem hiding this comment.
Then crmsh.utils.check_passwordless_between_nodes is useless, should be removed
… node (bsc#1213797) During a rolling upgrade, some of the cluster nodes may be unreachable. In certain cases, it takes a long time to wait for a EHOSTUNREACH error. Reducing the timeout helps crmsh to detect unreachable nodes faster and to give up quickly.
nicholasyang2022
force-pushed
the
upgradeutil_timeout
branch
from
548eb4b
to
2c11580
Compare
Codecov Report
@@ Coverage Diff @@
## master #1222 +/- ##
==========================================
+ Coverage 43.18% 52.50% +9.32%
==========================================
Files 78 78
Lines 25012 24996 -16
==========================================
+ Hits 10801 13125 +2324
+ Misses 14211 11871 -2340
|
liangxin1300
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During a rolling upgrade, some of the cluster nodes may be unreachable.
In certain cases, it takes a long time to wait for a EHOSTUNREACH error.
Reducing the timeout helps crmsh to detect unreachable nodes faster and
to give up quickly.