[crmsh-4.5] Fix: ui_cluster: Improve the process of 'crm cluster stop' (bsc#1213889) #1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
liangxin1300
commented
Aug 3, 2023
•
liangxin1300
commented
- Fix bsc#1213889: don't try to get DC when local service is unavailable
- Create nested functions to make the whole process clear
- Support checking and setting dlm option on remote node
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## crmsh-4.5 #1228 +/- ##
=============================================
+ Coverage 52.38% 52.40% +0.01%
=============================================
Files 78 78
Lines 25097 25115 +18
=============================================
+ Hits 13148 13162 +14
- Misses 11949 11953 +4 ☔ View full report in Codecov by Sentry. |
liangxin1300
force-pushed
the
20230803_stop_cluster_all_crmsh45
branch
5 times, most recently
from
fe55ace
to
384af5c
Compare
liangxin1300
changed the title
liangxin1300
force-pushed
the
20230803_stop_cluster_all_crmsh45
branch
from
384af5c
to
07004dd
Compare
|
backport #1232 |
liangxin1300
force-pushed
the
20230803_stop_cluster_all_crmsh45
branch
2 times, most recently
from
caf3d25
to
d992cfd
Compare
liangxin1300
force-pushed
the
20230803_stop_cluster_all_crmsh45
branch
2 times, most recently
from
d49b7eb
to
9d19c91
Compare
- Fix bsc#1213889: don't try to get DC when local service is unavailable - Split into small functions to make the whole process clear - Support checking and setting dlm option on remote node
liangxin1300
force-pushed
the
20230803_stop_cluster_all_crmsh45
branch
from
9d19c91
to
1fcb08c
Compare
nicholasyang2022
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.