Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crmsh-4.5] Fix: codecov: use token in plaintext #1230

Conversation

nicholasyang2022
Copy link
Collaborator

As secrets in Github Actions are not provided to pull requests, the
codecov token has to be provided in plaintext. This token is only
authorized to upload reports to codecov.

See codecov/codecov-action#557.
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #1230 (1b6bae9) into crmsh-4.5 (341044e) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           crmsh-4.5    #1230   +/-   ##
==========================================
  Coverage      52.35%   52.36%           
==========================================
  Files             78       78           
  Lines          25099    25099           
==========================================
+ Hits           13141    13142    +1     
+ Misses         11958    11957    -1     

see 1 file with indirect coverage changes

@nicholasyang2022 nicholasyang2022 marked this pull request as draft August 4, 2023 10:22
Separate the checks and deliveries into two workflows.

* crmsh-ci.yml runs checks for pull requests.
* crmsh-cd.yml runs deliveries for new pushes to ClusterLab/crmsh:crmsh-4.5
@nicholasyang2022 nicholasyang2022 marked this pull request as ready for review August 7, 2023 09:38
@liangxin1300 liangxin1300 self-requested a review August 8, 2023 21:51
@liangxin1300 liangxin1300 merged commit ddb17a0 into ClusterLabs:crmsh-4.5 Aug 8, 2023
29 checks passed
@nicholasyang2022 nicholasyang2022 deleted the fix_codecov_rate_limit_4.5 branch August 14, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants