Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crmsh-4.6] Dev: remove upgradeutil and add crm cluster health hawk2 [--fix] (bsc#1228899) #1559

Merged

Conversation

nicholasyang2022
Copy link
Collaborator

When passwordless ssh authentication for hacluster is not set up,
upgradeutil tries to set it up before any subcommand runs. This runs
silently and suprise users when some error happens. For example,
dropping ssh packets between hosts will make ssh processes to block
at connect(2) system call.

So, we will not use upggradeutil to setup ssh authentication for
hacluster any longer.
…ster passwordless ssh authentication (bsc#1228899)
… initialize ssh (bsc#1228899)

It is impossible to set up passwordless authenticaiton automatically if
`ssh` stage never runs in a cluster. When `crm cluster health hawk2
--fix` detects this problem, print a message to remind the user to run
ssh bootstrap.
@nicholasyang2022 nicholasyang2022 changed the title Dev: remove upgradeutil and add crm cluster health hawk2 [--fix] (bsc#1228899) [crmsh-4.6] Dev: remove upgradeutil and add crm cluster health hawk2 [--fix] (bsc#1228899) Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 76.81159% with 16 lines in your changes missing coverage. Please review.

Project coverage is 67.28%. Comparing base (e6f00fb) to head (038d5cc).
Report is 9 commits behind head on crmsh-4.6.

Files with missing lines Patch % Lines
crmsh/scripts.py 53.84% 6 Missing ⚠️
crmsh/ui_cluster.py 80.00% 6 Missing ⚠️
crmsh/healthcheck.py 84.00% 4 Missing ⚠️
Additional details and impacted files
Flag Coverage Δ
integration 52.98% <76.81%> (-0.65%) ⬇️
unit 49.70% <14.49%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crmsh/bootstrap.py 84.59% <ø> (-0.06%) ⬇️
crmsh/main.py 54.32% <ø> (-0.38%) ⬇️
crmsh/user_of_host.py 95.74% <100.00%> (ø)
crmsh/healthcheck.py 55.13% <84.00%> (+2.63%) ⬆️
crmsh/scripts.py 71.85% <53.84%> (-0.21%) ⬇️
crmsh/ui_cluster.py 75.91% <80.00%> (-2.66%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicholasyang2022 nicholasyang2022 marked this pull request as ready for review September 23, 2024 05:56
@liangxin1300 liangxin1300 merged commit 127d4da into ClusterLabs:crmsh-4.6 Sep 24, 2024
31 of 32 checks passed
@nicholasyang2022 nicholasyang2022 deleted the bsc_1228899_20240913-4.6 branch September 30, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants