Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: help: crm help <topic> does not work (#1567) #1568

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

nicholasyang2022
Copy link
Collaborator

  1. When len(args) is 1, should check if it is a topic first.
  2. Should check _is_command() or _is_level() before calling help_command().
  3. Refine the error message printed when no suitable help entries are found.

Fixes #1567.

1. When len(args) is 1, should check if it is a topic first.
2. Should check _is_command() or _is_level() before calling
   help_command().
3. Refine the error message printed when no suitable help entries are
   found.

Fixes ClusterLabs#1567.
@nicholasyang2022 nicholasyang2022 marked this pull request as ready for review September 27, 2024 04:55
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.76%. Comparing base (e5c5acf) to head (61322a8).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
crmsh/help.py 50.00% 2 Missing ⚠️
Additional details and impacted files
Flag Coverage Δ
integration 54.57% <50.00%> (-0.01%) ⬇️
unit 52.62% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crmsh/help.py 88.85% <50.00%> (+0.22%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liangxin1300 liangxin1300 merged commit 3727fc0 into ClusterLabs:master Sep 27, 2024
31 of 32 checks passed
@nicholasyang2022 nicholasyang2022 deleted the fix-1567 branch September 30, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to get topics help
2 participants