Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crmsh-4.5] Dev: utils: Introduced detect_duplicate_device_path function in utils #1584

Conversation

liangxin1300
Copy link
Collaborator

backport from #1582

- A new function `detect_duplicate_device_path` has been added to `utils.py`.
- This function checks for duplicated device paths in a given list of devices,
  raising a ValueError if duplicates are found.
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 65.74%. Comparing base (80d011e) to head (f88204b).
Report is 7 commits behind head on crmsh-4.5.

Files with missing lines Patch % Lines
crmsh/utils.py 22.22% 7 Missing ⚠️
crmsh/sbd.py 0.00% 1 Missing ⚠️
Additional details and impacted files
Flag Coverage Δ
integration 51.81% <20.00%> (-0.02%) ⬇️
unit 47.46% <20.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crmsh/sbd.py 91.68% <0.00%> (-0.24%) ⬇️
crmsh/utils.py 68.59% <22.22%> (-0.20%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liangxin1300 liangxin1300 marked this pull request as ready for review October 12, 2024 01:51
@liangxin1300 liangxin1300 merged commit 3a32b36 into ClusterLabs:crmsh-4.5 Oct 14, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants