Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: hahealth: return fail when report failed (bsc#1231840) #1589

Conversation

aleksei-burlakov
Copy link
Contributor

This will help external applications (e.g. hawk) better understand the result of the 'crm script run health' execution.

aleksei-burlakov pushed a commit to aleksei-burlakov/crmsh that referenced this pull request Oct 21, 2024
…abs#1589)

This will help external applications (e.g. hawk) better understand
the result of the 'crm script run health' execution.
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.55%. Comparing base (0573690) to head (6fa784d).

Additional details and impacted files
Flag Coverage Δ
integration 54.31% <ø> (ø)
unit 52.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@nicholasyang2022 nicholasyang2022 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And should we also change this line?

scripts/health/hahealth.py Show resolved Hide resolved
…abs#1589)

This will help external applications (e.g. hawk) better understand
the result of the 'crm script run health' execution.
@liangxin1300 liangxin1300 merged commit bf02867 into ClusterLabs:master Oct 25, 2024
28 of 30 checks passed
@nicholasyang2022
Copy link
Collaborator

@liangxin1300 We have test failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants