Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: libpe_rules: New timezone attribute in date_expression of rules #3068

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Feature: libpe_rules: New timezone attribute in date_expression of rules #3068

wants to merge 10 commits into from

Commits on Oct 10, 2023

  1. Refactor: libpe_rules: Rename pe_cron_range_satisfied to pe__ 

    Internal-only

Signed-off-by: Reid Wahl <[email protected]>
    @nrwahl2
    nrwahl2 committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    fb0e521 View commit details
    Browse the repository at this point in the history

  2. Refactor: libpe_rules: Rename pe_unpack_alerts to pe__ 

    Internal-only

Signed-off-by: Reid Wahl <[email protected]>
    @nrwahl2
    nrwahl2 committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    576066b View commit details
    Browse the repository at this point in the history

  3. Refactor: libpe_rules: Rename pe_free_alert_list to pe__ 

    Internal-only

Signed-off-by: Reid Wahl <[email protected]>
    @nrwahl2
    nrwahl2 committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    273e05a View commit details
    Browse the repository at this point in the history

  4. Refactor: libcrmcommon: New function to get timezone correctly 

    crm_time_get_timezone() should convert dt->offset to hours and minutes,
rather than converting dt->seconds. Additionally, the output variables
must be signed, since the offset can be negative.

However, we can't change the interface since it's public API. Create a
new internal function to get timezone correctly.

Signed-off-by: Reid Wahl <[email protected]>
    @nrwahl2
    nrwahl2 committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    ce6095e View commit details
    Browse the repository at this point in the history

  5. API: libcrmcommon: Deprecate crm_time_get_timezone() 

    This function has never worked correctly (it uses dt->seconds instead of
dt->offset, and it stores output values as unsigned). Nothing uses it
internally, so we deprecate it here. It will be removed in a future
release.

Signed-off-by: Reid Wahl <[email protected]>
    @nrwahl2
    nrwahl2 committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    e5b578c View commit details
    Browse the repository at this point in the history

  6. Refactor: libcrmcommon: New function to set timezone for crm_time_t 

    Given a timezone expressed as hours and minutes offset from UTC, adjust
the object's time to match the timezone and then set the object's
timezone.

Signed-off-by: Reid Wahl <[email protected]>
    @nrwahl2
    nrwahl2 committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    a0ad7f8 View commit details
    Browse the repository at this point in the history

  7. API: libcrmcommon: New PCMK_XA_TIME_ZONE string constant 

    This will be used as a new cluster property name.

Ref T646

Signed-off-by: Reid Wahl <[email protected]>
    @nrwahl2
    nrwahl2 committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    92b9274 View commit details
    Browse the repository at this point in the history

  8. Feature: libcrmcommon: Bump feature set for cluster-timezone property 

    For the new "timezone" attribute of date_expression elements in rules.

Ref T646

Signed-off-by: Reid Wahl <[email protected]>
    @nrwahl2
    nrwahl2 committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    17aacdb View commit details
    Browse the repository at this point in the history

  9. Doc: Pacemaker Explained: Document rule:date_expression:timezone 

    Closes T646
Closes RHBZ#2183466

Signed-off-by: Reid Wahl <[email protected]>
    @nrwahl2
    nrwahl2 committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    67e6d36 View commit details
    Browse the repository at this point in the history

  10. WIP: timezone property 

    Signed-off-by: Reid Wahl <[email protected]>
    @nrwahl2
    nrwahl2 committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    4c24f97 View commit details
    Browse the repository at this point in the history