Low: cts: Don't include the digest in expected output. #3709
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgaillot
reviewed
Oct 28, 2024
We are seeing a problem during test builds where the digest can differ. This problem has not been seen when doing builds locally with mock, nor on the clusterlabs CI infrastructure. It additionally does not seem to be a symptom of any other problem, since we've had no reports with weird CIB differing problems. Note that the digest was not included in the expected output from the moment it was first committed in 2008 until I converted cts-cli.in to python. Presumedly, this was originally done because the input CIB would be changing and they didn't also want to have to remember to change the expected output. Unfortunately, this makes it difficult to know if we would have been seeing these digest differences all along.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are seeing a problem during test builds where the digest can differ. This problem has not been seen when doing builds locally with mock, nor on the clusterlabs CI infrastructure. It additionally does not seem to be a symptom of any other problem, since we've had no reports with weird CIB differing problems.
Note that the digest was not included in the expected output from the moment it was first committed in 2008 until I converted cts-cli.in to python Presumedly, this was originally done because the input CIB would be changing and they didn't also want to have to remember to change the expected output. Unfortunately, this makes it difficult to know if we would have been seeing these digest differences all along.