-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise macOS default deployment target #636
base: master
Are you sure you want to change the base?
Raise macOS default deployment target #636
Conversation
This is a breaking change, since it will dirty everyone’s Podfile.lock that contains a pod that is using the default |
What does that mean for me? Is there some documentation or other action by me required, or do I just need to wait for other devs/maintainers to chime in? |
@DarkDust it probably means we cant merge it until we ship a 2.0 version of CocoaPods. For your original issue just supply the version of macOS in your |
I did specify |
Just FYI this is also happening with iOS projects since iOS 8.0 is no longer supported. What's the solution here? It's expected that Pods update and specify a version instead of relying on the defaults? |
@dnkoutso @segiddins I'm not sure about the requirement "wait for 2.0.0 Cocoapods version" here. CocoaPods currently set If you would update these default values to
So current default values don't work and don't make project compilable, right? Thanks |
@Kaspik See discussions at CocoaPods/CocoaPods#10070 and CocoaPods/CocoaPods#9884 tldr: podspecs and Podfiles should be updated |
I saw it (I even was part of the convo: CocoaPods/CocoaPods#9884 (comment)), but that doesn't change anything on my comment, right? Either CocoaPods should not have Another option would be set the |
@Kaspik Sorry, on a closer read, I see your point, I was answering about a Podfile default versus a podspec default. The potential breakage with changing the podspec default is much more theoretical - a pod using an iOS 8 API that is deprecated or deleted in iOS 9 and consumers still using Xcode 11. However, it would still broken either way with Xcode 12. |
Hmmm, yeah, theoretically yes... Is there any reason why not to come up with 2.0.0 instead of 1.11.0 then? Or what's the timeline for CocoaPods for upcoming months? This seems like a reasonable update sooner rather than later. |
Raise the default deployment target for macOS from 10.6 to 10.9. This gets rid of a warning in Xcode 12 with pods that did not explicitly specify a deployment target.
Closes CocoaPods/CocoaPods#9884