Fix TypeScript Errors and add Redux #64
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 21, 2019 11:01
added 2 commits
November 24, 2019 13:07
Vpr99
approved these changes
Dec 2, 2019
| @@ -49,14 +49,18 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@types/jest": "^24.0.23", | |||
| "@types/node": "^12.12.11", | |||
There was a problem hiding this comment.
I'm curious, what do we need Node types for?
There was a problem hiding this comment.
I think this was an issue to do with making TypeScript recognize process.env as a global. I should look into it as it's been a few weeks.
| export const useCategories = () => {}; | ||
|
|
||
| // Returns a list of subtypes for a category | ||
| //export const useSubTypes = category => {}; |
There was a problem hiding this comment.
Are these being used? If not could we get rid of them for now?
There was a problem hiding this comment.
Yeah for sure. I think for now, I should remove any code like this or that isn't being used. The app doesn't use redux yet, but I think it'd be good to merge in TypeScript for now.
|
Because of git wierdness, I'm creating a new PR for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in Progress
Redux Refactoring
Close #54 - WIP, but TypeScript & redux were added and have basic setup
redux react-redux redux-thunk/src/index.htmluseAPIwith redux/categoriesand/searchpages toFixed TypeScript Path Error
@types/nodeto allowprocessto be typed globally.My solution: Use
tsconfig.json,package.jsonand the official parcel docs to fix this.