Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Redux to the app #68

Merged
merged 20 commits into from
Jan 18, 2020
Merged

Add Redux to the app #68

merged 20 commits into from
Jan 18, 2020

Conversation

Alex-Cannon
Copy link
Collaborator

@Alex-Cannon Alex-Cannon commented Dec 22, 2019

I'm working on converting the /categories pages to use redux. This was previously in my PR #64, which I closed because of git weirdness.

  • Installed redux react-redux redux-thunk
  • Added /types directory for TypeScript types
  • Converted categories/index.jsx
  • Converted types/index.jsx
  • Converted services/index.jsx
  • Converted service-detail/index.jsx
  • Fix search that I broke :(

After this is merged, I'll work on testing the functionality with react-testing-library

@Alex-Cannon Alex-Cannon added the tech debt Issue / request to improve development label Dec 22, 2019
Copy link
Contributor

@Vpr99 Vpr99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really solid work @Alex-Cannon. Thanks for taking care of all this :) Just had a few pretty minor thoughts.

package.json Outdated Show resolved Hide resolved
tsconfig.json Show resolved Hide resolved
src/core/api/services/useServices.ts Outdated Show resolved Hide resolved
src/core/api/services/useServices.ts Outdated Show resolved Hide resolved
src/core/utils.ts Outdated Show resolved Hide resolved
src/index.tsx Outdated Show resolved Hide resolved
src/core/utils.ts Outdated Show resolved Hide resolved
src/pages/categories/index.jsx Outdated Show resolved Hide resolved
src/pages/categories/index.jsx Outdated Show resolved Hide resolved
src/pages/service-detail/index.jsx Show resolved Hide resolved
Copy link
Collaborator Author

@Alex-Cannon Alex-Cannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vpr99 I made all the changes you requested. Let me know if this is good to go.

@Alex-Cannon Alex-Cannon merged commit 55105a1 into master Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt Issue / request to improve development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants