This repository has been archived by the owner on Jan 14, 2024. It is now read-only.
London10-Afsha Hossain-HTML/CSS - Week 1 #332
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JarrodFolinoFC
suggested changes
Feb 6, 2023
Comment on lines
+32
to
+36
| .menu { | ||
| display: flex; | ||
| flex-direction: row; | ||
| justify-content: center; | ||
| } |
There was a problem hiding this comment.
this is great. It is best practise using the class
Comment on lines
+38
to
+61
| button { | ||
| padding: 1rem 1rem; | ||
| margin: 1rem; | ||
| font-size: 20px; | ||
| border-radius: 10px; | ||
| } | ||
|
|
||
| main { | ||
| padding: 2rem; | ||
| } | ||
|
|
||
| article { | ||
| margin: 5rem 0; | ||
| } | ||
|
|
||
|
|
||
| article:first-child { | ||
| font-size: larger; | ||
| color: darkblue; | ||
| } | ||
|
|
||
| footer { | ||
| text-align: center; | ||
| } |
There was a problem hiding this comment.
The styles are good. Maybe try and do it with the css class like you did on line 32
| <main> | ||
| <article> | ||
| <h2>Experiencing Peace and Joy</h2> | ||
| <img src="http://data.freehdw.com/bridge-over-the-green-river.jpg" alt="Lake reflecting green trees surronding the lake. There is a long wooden bridge over the lake"> |
There was a problem hiding this comment.
can we download the image and link to it with a relative path <img src="images/picture.jpg">
| </article> | ||
| <article> | ||
| <h2>Experiencing Peace</h2> | ||
| <img src="http://images.freehdw.com/800/nature-landscapes_other_wooden-house-in-forest_3295.jpg" alt="Small house in a forest. Morning sunrays falling over the trees and top of the house." |
There was a problem hiding this comment.
can we download the image and link to it with a relative path <img src="images/picture.jpg">
Comment on lines
49
to
50
| <!-- Add your HTML markup here --> | ||
| <!-- Remember: Use semantic HTML tags like <header>, <main>, <nav>, <footer>, <section> etc --> |
There was a problem hiding this comment.
Can we delete these lines that are comments
|
|
||
| </article> | ||
| </main> | ||
| <footer>© 2023 Created with 💚 by Afsha</footer> |
There was a problem hiding this comment.
Can we use a html entity, see https://www.w3schools.com/html/html_entities.asp
©
| @@ -16,6 +16,36 @@ | |||
| <link rel="shortcut icon" type="image/x-icon" href="favicon.ico" /> | |||
| </head> | |||
| <body> | |||
| <header> | |||
| <nav> | |||
| <h1>Peace and Joy</h1> | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… page
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?