Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Term Entry] Python Plotly- graph_objects .Surface() #5219

Merged
merged 17 commits into from
Nov 14, 2024
Merged

[Term Entry] Python Plotly- graph_objects .Surface() #5219

merged 17 commits into from
Nov 14, 2024

Conversation

saldanhad
Copy link
Contributor

Description

Changes from the previous PR having been implemented in this.

Issue Solved

closes #5179

Type of Change

  • Adding a new entry

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@SaviDahegaonkar SaviDahegaonkar self-assigned this Sep 15, 2024
@SaviDahegaonkar SaviDahegaonkar added new entry New entry or entries python Python entries status: under review Issue or PR is currently being reviewed plotly Python:Plotly entries labels Sep 15, 2024
SaviDahegaonkar
SaviDahegaonkar suggested changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@SaviDahegaonkar SaviDahegaonkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @saldanhad ,
I must say the entry is nicely written.I have suggested a change to you please make it asap, so I can approve this PR.

Thanks,
Savi

content/plotly/concepts/graph-objects/terms/surface/surface.md Outdated Show resolved Hide resolved
SaviDahegaonkar
SaviDahegaonkar approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@SaviDahegaonkar SaviDahegaonkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @saldanhad ,
Your entry LGTM! It looks good for a second round of review.

Thanks,
Savi

@saldanhad
minor change to title
d483672 
changed title to maintain consistency
@avdhoottt avdhoottt added status: ready for next review and removed status: under review Issue or PR is currently being reviewed labels Sep 19, 2024
@avdhoottt avdhoottt self-assigned this Sep 19, 2024
@avdhoottt avdhoottt added status: under review Issue or PR is currently being reviewed and removed status: ready for next review labels Sep 19, 2024
avdhoottt
avdhoottt requested changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@avdhoottt avdhoottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Author, I have reviewed the entry and suggested some changes. Please make them and ping me one you are done. Thanks!!

content/plotly/concepts/graph-objects/terms/surface/surface.md Outdated Show resolved Hide resolved
content/plotly/concepts/graph-objects/terms/surface/surface.md Outdated Show resolved Hide resolved
content/plotly/concepts/graph-objects/terms/surface/surface.md Outdated Show resolved Hide resolved
content/plotly/concepts/graph-objects/terms/surface/surface.md Outdated Show resolved Hide resolved
content/plotly/concepts/graph-objects/terms/surface/surface.md Outdated Show resolved Hide resolved
@avdhoottt avdhoottt removed the status: under review Issue or PR is currently being reviewed label Sep 20, 2024
@saldanhad saldanhad requested a review from avdhoottt September 21, 2024 12:44
@saldanhad saldanhad mentioned this pull request Sep 26, 2024
Merged
9 tasks
@saldanhad
Copy link
Contributor Author

@SaviDahegaonkar @avdhoottt can we have some moment on this, kindly merge if all good, or please suggest if any changes required, thanks

avdhoottt
avdhoottt approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@avdhoottt avdhoottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@avdhoottt avdhoottt merged commit f52e5d5 into Codecademy:main Nov 14, 2024
5 checks passed
@github-actions GitHub Actions
Copy link

👋 @saldanhad
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/plotly/graph-objects/surface

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, see here.

@saldanhad saldanhad deleted the dev branch November 25, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avdhoottt avdhoottt avdhoottt approved these changes

@SaviDahegaonkar SaviDahegaonkar Awaiting requested review from SaviDahegaonkar

Assignees

@avdhoottt avdhoottt

@SaviDahegaonkar SaviDahegaonkar

Labels
new entry New entry or entries plotly Python:Plotly entries python Python entries status: review 1️⃣ completed status: review 2️⃣ completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Term Entry] Python Plotly- graph_objects .Surface()
3 participants
@saldanhad @avdhoottt @SaviDahegaonkar