Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor RegExp Documentation: Fix Typos and Enhance Formatting; #5449

Merged
merged 15 commits into from
Nov 14, 2024
Merged

Refactor RegExp Documentation: Fix Typos and Enhance Formatting; #5449

merged 15 commits into from
Nov 14, 2024

Conversation

A-Berezvay
Copy link
Contributor

Description

Issue Solved

Type of Change

  • Adding a new entry
  • Editing an existing entry (fixing a typo, bug, issues, etc)
  • Updating the documentation

Checklist

  • [ x] All writings are my own.
  • [ x] My entry follows the Codecademy Docs style guide.
  • [ x] My changes generate no new warnings.
  • [ x] I have performed a self-review of my own writing and code.
  • [x ] I have checked my entry and corrected any misspellings.
  • [ x] I have made corresponding changes to the documentation if needed.
  • [ x] I have confirmed my changes are not being pushed from my forked main branch.
  • [x ] I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • [ x] I have linked any issues that are relevant to this PR in the Issues Solved section.

@CLAassistant
Copy link

CLAassistant commented Oct 11, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@dakshdeepHERE dakshdeepHERE self-assigned this Oct 11, 2024
@dakshdeepHERE dakshdeepHERE linked an issue Oct 11, 2024 that may be closed by this pull request
[Edit] JavaScript RegExp #5380
Closed
3 tasks
@dakshdeepHERE dakshdeepHERE added enhancement New feature or request javascript JavaScript entries hacktoberfest-accepted Indicates the PR was approved, merged, and pertains to Hacktoberfest status: under review Issue or PR is currently being reviewed labels Oct 11, 2024
@dakshdeepHERE
Copy link
Collaborator

Thanks for raising the PR @A-Berezvay, I'll be reviewing it now also please sign the CLA document :)

@A-Berezvay
Copy link
Contributor Author

Great thank you! Let me know if anything require further assistance :)

@A-Berezvay
Copy link
Contributor Author

Hi @dakshdeepHERE , could you please review this PR when you have a chance? Thanks!

dakshdeepHERE
dakshdeepHERE approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@dakshdeepHERE dakshdeepHERE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes from my side and this looks good for second review.

@avdhoottt avdhoottt added status: under review Issue or PR is currently being reviewed and removed status: ready for next review labels Oct 18, 2024
@avdhoottt avdhoottt self-assigned this Oct 18, 2024
avdhoottt
avdhoottt reviewed Oct 20, 2024
View reviewed changes
content/javascript/concepts/regexp/regexp.md Outdated

1. **Literal Notation**: Use slashes to delimit the pattern, followed by any flags.
```pseudo
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use ```js for the codeblock.

avdhoottt
avdhoottt approved these changes Oct 20, 2024
View reviewed changes
Copy link
Collaborator

@avdhoottt avdhoottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @A-Berezvay, excellent entry! I have only one change to be made. Please do it as soon as possible. Thanks!!

content/javascript/concepts/regexp/regexp.md Outdated

// Using RegExp constructor
2. **Constructor Function**: Use the `RegExp` constructor, passing the pattern as the first argument and any flags as the second.
```pseudo
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use ```js for the codeblock.

A-Berezvay and others added 2 commits October 22, 2024 10:28
@A-Berezvay
Merge branch 'Codecademy:main' into update-js-regexp-docs
1a20a11
@Radhika-okhade
Update regexp.md
cd96a29 
Fixed minor issues like adding line breaks and updating example headings to example 1 and example 2.
avdhoottt
avdhoottt approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@avdhoottt avdhoottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@avdhoottt avdhoottt merged commit 52a8efe into Codecademy:main Nov 14, 2024
6 checks passed
@github-actions GitHub Actions
Copy link

👋 @A-Berezvay
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/javascript/regexp

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, see here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avdhoottt avdhoottt avdhoottt approved these changes

@dakshdeepHERE dakshdeepHERE dakshdeepHERE approved these changes

@Radhika-okhade Radhika-okhade Radhika-okhade approved these changes

Assignees

@avdhoottt avdhoottt

@dakshdeepHERE dakshdeepHERE

Labels
enhancement New feature or request hacktoberfest-accepted Indicates the PR was approved, merged, and pertains to Hacktoberfest javascript JavaScript entries status: review 1️⃣ completed status: review 2️⃣ completed status: waiting for author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Edit] JavaScript RegExp
5 participants
@A-Berezvay @CLAassistant @dakshdeepHERE @avdhoottt @Radhika-okhade