Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Concept Entry] C: Static Variables #5982

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

deedend
Copy link

@deedend deedend commented Jan 16, 2025

Description

  • Added static variables concept as part of the kanban project for Git/Github course

Issue Solved

Closes #5955

Type of Change

  • Adding a new entry

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@CLAassistant
Copy link

CLAassistant commented Jan 16, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ mamtawardhani
✅ Radhika-okhade
❌ Daniele V


Daniele V seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@deedend
Copy link
Author

deedend commented Jan 16, 2025

I've signed the CLA, and my account has an email associated to it. But still, it doesn't recognise the signature!

@mamtawardhani mamtawardhani self-assigned this Jan 17, 2025
@mamtawardhani mamtawardhani added c C entries new entry New entry or entries status: under review Issue or PR is currently being reviewed labels Jan 17, 2025
Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing to Codecademy Docs @deedend 😄

The entry looks good for a second round of review! 🚀

@mamtawardhani
Copy link
Collaborator

I've signed the CLA, and my account has an email associated to it. But still, it doesn't recognise the signature!

It looks like you've done a commit on your local device using a local id, so an email related to that would be required here. Can you please try signing the CLA with the local id

@Radhika-okhade Radhika-okhade added status: under review Issue or PR is currently being reviewed and removed status: ready for next review labels Jan 22, 2025
@Radhika-okhade Radhika-okhade self-assigned this Jan 22, 2025
@Radhika-okhade Radhika-okhade added status: waiting for author and removed status: under review Issue or PR is currently being reviewed labels Jan 22, 2025
@Radhika-okhade
Copy link
Collaborator

Once the CLA is signed, we can merge the entry @deedend

@deedend
Copy link
Author

deedend commented Jan 23, 2025

I'm sorry but I have no idea how to do that. I have my email set up in GitHub, how can I see what email is associated with the commit?

@deedend
Copy link
Author

deedend commented Jan 23, 2025

I've signed the CLA, and my account has an email associated to it. But still, it doesn't recognise the signature!

It looks like you've done a commit on your local device using a local id, so an email related to that would be required here. Can you please try signing the CLA with the local id

Where can I see that id? And how can I use it to sign the CLA?

@mamtawardhani
Copy link
Collaborator

I've signed the CLA, and my account has an email associated to it. But still, it doesn't recognise the signature!

It looks like you've done a commit on your local device using a local id, so an email related to that would be required here. Can you please try signing the CLA with the local id

Where can I see that id? And how can I use it to sign the CLA?

Hey @Sriparno08, @daksh10110, and @avdhoottt, can any of you help @deedend understand where the local email ID can be found? It seems that the initial commit has been made through that.

@Sriparno08
Copy link
Collaborator

Hey @deedend, run the following command while on the static-variables branch:

git log db4b698

Here, db4b698 is the commit hash of the initial commit.

After running the above command, the details for the commit is shown. Check out the Author entry in there to find the email associated with the commit.

@mamtawardhani
Copy link
Collaborator

Hey @

Hey @deedend, run the following command while on the static-variables branch:

git log db4b698

Here, db4b698 is the commit hash of the initial commit.

After running the above command, the details for the commit is shown. Check out the Author entry in there to find the email associated with the commit.

Hey @deedend did this work?

@deedend
Copy link
Author

deedend commented Jan 30, 2025

Hey @

Hey @deedend, run the following command while on the static-variables branch:

git log db4b698

Here, db4b698 is the commit hash of the initial commit.
After running the above command, the details for the commit is shown. Check out the Author entry in there to find the email associated with the commit.

Hey @deedend did this work?

Hello @mamtawardhani , sorry I've been flooded as of late, and I did the commit on my home computer so I have to take the time to deal with that when I'm at home. I will try as soon as possible. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Concept Entry] C: Static Variables
5 participants