Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added documentation page of C++ access modifier: protected #5998

Merged
merged 20 commits into from
Jan 25, 2025
Merged

Added documentation page of C++ access modifier: protected #5998

merged 20 commits into from
Jan 25, 2025

Conversation

E1StOrm
Copy link
Contributor

@E1StOrm E1StOrm commented Jan 21, 2025 •
edited
Loading

Description

Hes been created:
file docs/content/cpp/concepts/access-modifiers/terms/protected/protected.md
and path part: /access-modifiers/terms/protected/

Issue Solved

Closes #5978

Type of Change

  • Adding a new entry
  • Updating the documentation

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@CLAassistant
Copy link

CLAassistant commented Jan 21, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@PragatiVerma18 PragatiVerma18 self-assigned this Jan 22, 2025
PragatiVerma18
PragatiVerma18 requested changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@PragatiVerma18 PragatiVerma18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @E1StOrm, thanks for contributing to docs. The entry looks good, I have a few suggestions. Please check the comments and resolve them, then we will be good to go for a second review. Happy contributing! 🚀

content/cpp/concepts/access-modifiers/terms/protected/protected.md Outdated Show resolved Hide resolved
content/cpp/concepts/access-modifiers/terms/protected/protected.md Outdated Show resolved Hide resolved
content/cpp/concepts/access-modifiers/terms/protected/protected.md Show resolved Hide resolved
content/cpp/concepts/access-modifiers/terms/protected/protected.md Outdated Show resolved Hide resolved
content/cpp/concepts/access-modifiers/terms/protected/protected.md Outdated Show resolved Hide resolved
content/cpp/concepts/access-modifiers/terms/protected/protected.md Outdated Show resolved Hide resolved
content/cpp/concepts/access-modifiers/terms/protected/protected.md Outdated Show resolved Hide resolved
content/cpp/concepts/access-modifiers/terms/protected/protected.md Outdated Show resolved Hide resolved
content/cpp/concepts/access-modifiers/terms/protected/protected.md Outdated Show resolved Hide resolved
content/cpp/concepts/access-modifiers/terms/protected/protected.md Outdated Show resolved Hide resolved
E1StOrm and others added 11 commits January 22, 2025 21:29
@E1StOrm @PragatiVerma18
Update content/cpp/concepts/access-modifiers/terms/protected/protecte…
df17a41 
…d.md

Co-authored-by: Pragati Verma <[email protected]>
@E1StOrm @PragatiVerma18
Update content/cpp/concepts/access-modifiers/terms/protected/protecte…
5b514ef 
…d.md

Co-authored-by: Pragati Verma <[email protected]>
@E1StOrm @PragatiVerma18
Update content/cpp/concepts/access-modifiers/terms/protected/protecte…
348a85a 
…d.md

Co-authored-by: Pragati Verma <[email protected]>
@E1StOrm @PragatiVerma18
Update content/cpp/concepts/access-modifiers/terms/protected/protecte…
12f9f8a 
…d.md

Co-authored-by: Pragati Verma <[email protected]>
@E1StOrm @PragatiVerma18
Update content/cpp/concepts/access-modifiers/terms/protected/protecte…
5154edc 
…d.md

Co-authored-by: Pragati Verma <[email protected]>
@E1StOrm @PragatiVerma18
Update content/cpp/concepts/access-modifiers/terms/protected/protecte…
e82455f 
…d.md

Co-authored-by: Pragati Verma <[email protected]>
@E1StOrm @PragatiVerma18
Update content/cpp/concepts/access-modifiers/terms/protected/protecte…
8501c53 
…d.md

Co-authored-by: Pragati Verma <[email protected]>
@E1StOrm @PragatiVerma18
Update content/cpp/concepts/access-modifiers/terms/protected/protecte…
2c3f926 
…d.md

Co-authored-by: Pragati Verma <[email protected]>
@E1StOrm @PragatiVerma18
Update content/cpp/concepts/access-modifiers/terms/protected/protecte…
9ea962d 
…d.md

Co-authored-by: Pragati Verma <[email protected]>
@E1StOrm @PragatiVerma18
Update content/cpp/concepts/access-modifiers/terms/protected/protecte…
a462c17 
…d.md

Co-authored-by: Pragati Verma <[email protected]>
@E1StOrm
Merge branch 'main' into cpp_access_mod_protected
3d61a00
@E1StOrm
Copy link
Contributor Author

E1StOrm commented Jan 22, 2025

Thanks PragatiVerma18 for your help.

E1StOrm
E1StOrm commented Jan 23, 2025
View reviewed changes
Copy link
Contributor Author

@E1StOrm E1StOrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All recomendations applied.

PragatiVerma18
PragatiVerma18 approved these changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@PragatiVerma18 PragatiVerma18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @E1StOrm, thanks for making the changes so quickly, this entry seems good for a second review! 🚀

@Sriparno08 Sriparno08 self-assigned this Jan 24, 2025
@Sriparno08 Sriparno08 added status: under review Issue or PR is currently being reviewed and removed status: ready for next review labels Jan 24, 2025
Sriparno08
Sriparno08 approved these changes Jan 25, 2025
View reviewed changes
Copy link
Collaborator

@Sriparno08 Sriparno08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @E1StOrm!

@Sriparno08 Sriparno08 merged commit a070590 into Codecademy:main Jan 25, 2025
7 checks passed
@github-actions GitHub Actions
Copy link

👋 @E1StOrm
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/cpp/access-modifiers/protected

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, visit the linked accounts page and ensure that your GitHub account is linked.

@Sriparno08 Sriparno08 added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sriparno08 Sriparno08 Sriparno08 approved these changes

@PragatiVerma18 PragatiVerma18 PragatiVerma18 approved these changes

Assignees

@PragatiVerma18 PragatiVerma18

@Sriparno08 Sriparno08

Labels
c++ C++ entries new entry New entry or entries status: review 1️⃣ completed status: review 2️⃣ completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Term Entry] C++ Access Modifiers: Protected
4 participants
@E1StOrm @CLAassistant @PragatiVerma18 @Sriparno08