Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Icons): add ProductsBriefcaseIcon, SmileyHappyIcon, SmileySadIcon, SmileyIndifferentIcon, and SmileyStarEyesIcon #2808

Merged
merged 2 commits into from
Nov 27, 2023
Merged

feat(Icons): add ProductsBriefcaseIcon, SmileyHappyIcon, SmileySadIcon, SmileyIndifferentIcon, and SmileyStarEyesIcon #2808

merged 2 commits into from
Nov 27, 2023

Conversation

natalieweesh
Copy link
Contributor

@natalieweesh natalieweesh commented Nov 21, 2023 •
edited by jira bot
Loading

Overview

add ProductsBriefcaseIcon, SmileyHappyIcon, SmileySadIcon, SmileyIndifferentIcon, and SmileyStarEyesIcon

Screenshot 2023-11-21 at 3 53 14 PM
Screenshot 2023-11-21 at 3 53 11 PM Screenshot 2023-11-21 at 3 53 07 PM

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: LEGO-3551
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.

PR Links and Envs

Repository PR Link PR Env
Monolith Monolith PR Monolith Env
Portal Portal Link Portal Env
Another Repo Another Link Another Env

@natalieweesh natalieweesh requested a review from a team as a code owner November 21, 2023 20:54
@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://655d1ede6e85230cc441e9fa--gamut-preview.netlify.app

Deploy Logs

@natalieweesh natalieweesh requested review from a team, j10sanders and katiezutter and removed request for a team November 22, 2023 16:17
katiezutter
katiezutter approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@katiezutter katiezutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@natalieweesh natalieweesh added the Ship It :shipit: Automerge this PR when possible label Nov 27, 2023
@codecademydev codecademydev merged commit a885490 into main Nov 27, 2023
3 of 4 checks passed
@codecademydev codecademydev deleted the nw-interview-icons branch November 27, 2023 16:15
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aresnik11 aresnik11 aresnik11 approved these changes

@katiezutter katiezutter katiezutter approved these changes

@timjenkins timjenkins Awaiting requested review from timjenkins timjenkins is a code owner automatically assigned from Codecademy/gamut

@BandanaKM BandanaKM Awaiting requested review from BandanaKM BandanaKM is a code owner automatically assigned from Codecademy/gamut

@j10sanders j10sanders Awaiting requested review from j10sanders j10sanders was automatically assigned from Codecademy/outcomes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@natalieweesh @codecademydev @aresnik11 @katiezutter