Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Video): move Video off of scss #2944

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

aresnik11
Copy link
Contributor

@aresnik11 aresnik11 commented Oct 4, 2024

Overview

Moves Video off of scss plus an accessibility fix for markdown videos

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: GM-748
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.

PR Links and Envs

Repository PR Link PR Env
Monolith Monolith PR Monolith Env
Portal Portal Link Portal Env
Another Repo Another Link Another Env

@aresnik11 aresnik11 changed the title first stab at moving off scss [GM-748] Move Video off of scss Oct 17, 2024
@aresnik11 aresnik11 changed the title [GM-748] Move Video off of scss refactor(Video): move Video off of scss Oct 17, 2024
Copy link

nx-cloud bot commented Oct 17, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4224f79. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://6711558382b43a9ad0c10027--gamut-preview.netlify.app

Deploy Logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants