Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix again and not in the wrong way #2994

Merged
merged 1 commit into from
Dec 13, 2024
Merged

fix again and not in the wrong way #2994

merged 1 commit into from
Dec 13, 2024

Conversation

dreamwasp
Copy link
Contributor

Overview

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: [ABC-123]
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.

PR Links and Envs

Repository PR Link PR Env
Monolith Monolith PR Monolith Env
Portal Portal Link Portal Env
Another Repo Another Link Another Env

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Dec 13, 2024 •
edited
Loading

☁️ Nx Cloud Report

We didn't find any information for the current pull request with the commit 83b461a.
Please verify you are running the latest version of the NxCloud runner.

Check the Nx Cloud Source Control Integration documentation for more information.

Alternatively, you can contact us at [email protected].

Sent with 💌 from NxCloud.

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://675c5ba6288e053253849e34--gamut-preview.netlify.app

Deploy Logs

@dreamwasp dreamwasp marked this pull request as ready for review December 13, 2024 17:27
@dreamwasp dreamwasp requested a review from a team as a code owner December 13, 2024 17:27
@dreamwasp dreamwasp requested review from timjenkins, BandanaKM and jakemhiller and removed request for timjenkins and BandanaKM December 13, 2024 17:27
jakemhiller
jakemhiller approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@jakemhiller jakemhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@dreamwasp dreamwasp added the Ship It :shipit: Automerge this PR when possible label Dec 13, 2024
@codecademydev codecademydev merged commit 630e911 into main Dec 13, 2024
17 of 20 checks passed
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Dec 13, 2024
@codecademydev codecademydev deleted the cs-fix-deploy-command-again branch December 13, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakemhiller jakemhiller jakemhiller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dreamwasp @codecademydev @jakemhiller