Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(borderColors): adding semantic and colormode compatible colors for borderColor #3004

Merged
merged 11 commits into from
Jan 14, 2025

Conversation

LinKCoding
Copy link
Contributor

@LinKCoding LinKCoding commented Jan 7, 2025

Overview

Add semantic border colors to colormode

PR Checklist

Testing Instructions

Note:
'navy', 'navy-800', 'secondary', and 'text' are the same. So borderColors that used any of these named colors got updated to border-primary.

see: https://github.com/Codecademy/gamut/blob/main/packages/gamut-styles/src/variables/colors.ts#L44
and: https://github.com/Codecademy/gamut/blob/main/packages/gamut-styles/src/themes/core.ts#L75-L76

same idea for other named colors like text-secondary ==> border-secondary.
and text-disabled ==> border-disabled.

Gamut testing instructions:

  1. Go to the preview
  2. Go to the Colormode page
  3. Look over the table to see that border-primary, border-secondary, border-tertiary, and border-disabled have been added for both light and dark mode.
  4. Check out some components to see that the styling has been applied, e.g.: card, progressbar, the AboutHeader/ComponentHeader on any story.
  5. check over some components that use the border: 1 or border: 2 shorthand, e.g. Badge (tertiary)

Mono/Portal-App testing instructions:

  1. Visit the preview
  2. Checkover some components to see that their borders are updated, below are some examples to checkover
  3. Catalog page's hubspotlight (the box that has "Prepare for Top IT Certifications"
  4. Catalog page's cards
  5. Pricing page's FAQ section, the list items
  6. Feel free to check more!

Monolith/Codecademy testing instructions:

  1. Visit the preview
  2. check that updated components have their border colors updated,, below are some examples to checkover:
  3. the SVGs and radio selections in Appearance Settings
  4. Feel free to check more (there's not much tho in monolith tbh)

PR Links and Envs

Repository PR Link PR Env
Monolith Monolith PR Monolith Env
Portal Portal Link Portal Env

Copy link

nx-cloud bot commented Jan 7, 2025

View your CI Pipeline Execution ↗ for commit 44f1e75.


☁️ Nx Cloud last updated this comment at 2025-01-14 15:21:01 UTC

@LinKCoding LinKCoding marked this pull request as ready for review January 10, 2025 20:46
@LinKCoding LinKCoding requested a review from a team as a code owner January 10, 2025 20:46
Copy link
Contributor

@aresnik11 aresnik11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good and works great!!!

@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://678680f2576c8799def705b8--gamut-preview.netlify.app

Deploy Logs

@LinKCoding LinKCoding added the Ship It :shipit: Automerge this PR when possible label Jan 14, 2025
@codecademydev codecademydev merged commit 5e61c28 into main Jan 14, 2025
15 of 16 checks passed
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Jan 14, 2025
@codecademydev codecademydev deleted the kl-gm-861 branch January 14, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants