Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TagCelebration): ✨ A new illustration for the upcoming trial cancellation incentive #3011

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

zippyzow
Copy link
Contributor

@zippyzow zippyzow commented Jan 21, 2025

Overview

Add offer card illustration to gamut-illustrations to be used for the upcoming trial cancellation incentive.

PR Checklist

  • Related to designs: figma
  • Related to JIRA ticket: FLOW-1039
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Screenshot 2025-01-21 at 11 41 30 AM

Navigate to storybook to see new illustration called TagCelebration.
Update: Storybook not updating (ticket created to investigate issue). You will have to pull this branch down locally to see.

PR Links and Envs

Repository PR Env PR Link
Monolith N/A (no UI to check) Monolith PR
Portal N/A (no UI to check) Portal PR

Copy link

nx-cloud bot commented Jan 21, 2025

View your CI Pipeline Execution ↗ for commit 0642e96.


☁️ Nx Cloud last updated this comment at 2025-01-21 22:15:58 UTC


import { IllustrationProps } from './types';

export const TagCelebation: React.FC<IllustrationProps> = ({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: TagCelebration

@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://67901c6ff2301ba62bf5a6de--gamut-preview.netlify.app

Deploy Logs

@zippyzow zippyzow marked this pull request as ready for review January 22, 2025 14:47
@zippyzow zippyzow requested a review from a team as a code owner January 22, 2025 14:47
@zippyzow zippyzow requested review from jakemhiller, LinKCoding, a team, saghdaey and medhatnar and removed request for a team and medhatnar January 22, 2025 14:47
Copy link
Contributor

@dreamwasp dreamwasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i tested this locally and it looks good. there's something up with the netlify build process that i've added to the gamut backlog

@zippyzow zippyzow added the Ship It :shipit: Automerge this PR when possible label Jan 22, 2025
@codecademydev codecademydev merged commit 89f18d4 into main Jan 22, 2025
19 of 20 checks passed
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Jan 22, 2025
@codecademydev codecademydev deleted the hr-flow-1039-illustration branch January 22, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants