chore(Pagination): remove navigation option

[jrood]

Overview

When attempting to upgrade framer-motion, improved type checking alerted us to the fact that we were trying to set href on a button when using isNavigation for Pagination. Upon searching the monorepo and monolith, no usage of the isNavigation prop was found. Thus, it seems reasonable to upblock the upgrade by just removing this feature.

PR Checklist

• Related to designs:
• Related to JIRA ticket: [ABC-123]
• I have run this code to verify it works
• This PR includes unit tests for the code change
• This PR includes testing instructions tests for the code change
• The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

PR Links and Envs

Repository	PR Link	PR Env
Monolith	Monolith PR	Monolith Env
Portal	Monorepo PR	Portal Env

[nx-cloud]

View your CI Pipeline Execution ↗ for commit ccbb4ff.

---

☁️ Nx Cloud last updated this comment at 2025-01-22 17:27:03 UTC

[codecademydev]

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

[codecademydev]

🚀 Styleguide deploy preview ready!

https://67912a7d68c6af2f4fc2798e--gamut-preview.netlify.app

Deploy Logs

[dreamwasp]

for accessibility, our Pagination'Buttons' are polymorphic, so when they are provided a href they render as an a element (you'll see this in the Gamut page for Pagination if you inspect the isNavigation example). i can help with the framer-motion upgrades, the types can get pretty wacky with our more flexible components.

i will need to look into this more, but i find it hard to believe that none of our pagination components are used as navigation and this is likely just developer oversight... in the meantime, i'll cut a ticket to make the isNavigation no longer optional so folks are forced to think about it when using the component

[jrood]

Thanks @dreamwasp ! Yep, that's a good point. Maybe when developers have to think about which one to use, we'll discover places where we should be using isNavigation.

I had assumed that the type checking change after upgrading framer motion upgrade was an improvement, but perhaps it actually is a bug/failure to pick up on the HTMLAnchorElement | HTMLButtonElement union for ButtonBaseElements.