Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Tip): Fixes hover gap and click issues with ToolTips and PreviewTips #3018

Merged
merged 15 commits into from
Jan 31, 2025
Merged

fix(Tip): Fixes hover gap and click issues with ToolTips and PreviewTips #3018

merged 15 commits into from
Jan 31, 2025

Conversation

dreamwasp
Copy link
Contributor

@dreamwasp dreamwasp commented Jan 28, 2025 •
edited
Loading

Overview

Fix hover gap and click tooltip bugs on floating tooltips

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: [GM-915 + GM-945]
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

  • Head to ToolTip /docs/molecules-tips-tooltip--docs#floating-placement
  • Click the button and quickly move mouse away
  • See that the tip doesn't appear
  • See that the console.log fired in the onClick
  • Hover the over the button and move your mouse to over the tip
  • See the tip doesn't disappear until you move your mouse away
  • Head to PreviewTip and see the same behavior
  • $$$

PR Links and Envs

Repository PR Link PR Env
Monolith Monolith PR Monolith Env
Portal Portal Link Portal Env

@dreamwasp dreamwasp changed the title Cass gm 915 945 fix(Tooltip): floating bugs Jan 28, 2025
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jan 28, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 9406a9d.

☁️ Nx Cloud last updated this comment at 2025-01-30 19:59:08 UTC

@dreamwasp dreamwasp changed the title fix(Tooltip): floating bugs fix(Tip): Fixes hover gap and click issues with ToolTips and PreviewTips Jan 28, 2025
@dreamwasp dreamwasp marked this pull request as ready for review January 28, 2025 21:56
@dreamwasp dreamwasp requested a review from a team as a code owner January 28, 2025 21:56
aresnik11
aresnik11 approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@aresnik11 aresnik11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

LinKCoding
LinKCoding reviewed Jan 29, 2025
View reviewed changes
packages/gamut/src/Popover/styles.tsx Outdated
@@ -28,6 +28,7 @@ export const raisedDivVariants = variant({
},
});

const borderStyles = { borderColor: 'secondary', border: 1 } as const;
Copy link
Contributor

@LinKCoding LinKCoding Jan 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need borderColor: 'secondary'
border: 1 should already be: 1px solid ${colors['border-primary']}
see: https://github.com/Codecademy/gamut/blob/main/packages/gamut-styles/src/themes/core.ts
and border-primary and secondary both use navy-800

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good eye! will fix

dreamwasp and others added 4 commits January 29, 2025 13:56
@dreamwasp
kenny edit
3db13e5
@dreamwasp
remove test code
10a8064
@dreamwasp
Merge branch 'main' into cass-gm-915-945
723d424
@dreamwasp
fix: ToolTip single word wrap (#3019)
9406a9d 
* fix: ToolTip single word wrap

* fixed it

* fix floating tip

* revert test code
@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://679bda2291d9e2351ec54dcf--gamut-preview.netlify.app

Deploy Logs

@dreamwasp dreamwasp added the Ship It :shipit: Automerge this PR when possible label Jan 31, 2025
@codecademydev codecademydev merged commit 84030ff into main Jan 31, 2025
15 of 16 checks passed
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Jan 31, 2025
@codecademydev codecademydev deleted the cass-gm-915-945 branch January 31, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinKCoding LinKCoding LinKCoding left review comments

@aresnik11 aresnik11 aresnik11 approved these changes

@jakemhiller jakemhiller Awaiting requested review from jakemhiller jakemhiller is a code owner automatically assigned from Codecademy/gamut

@timjenkins timjenkins Awaiting requested review from timjenkins timjenkins is a code owner automatically assigned from Codecademy/gamut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dreamwasp @codecademydev @aresnik11 @LinKCoding