Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Illustration): Discount tag illustrations #3021

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(Illustration): Discount tag illustrations #3021

wants to merge 3 commits into from

Conversation

zippyzow
Copy link
Contributor

@zippyzow zippyzow commented Jan 30, 2025 •
edited
Loading

Overview

Adds the following illustrations:

  • Tag50PercentOff
  • Tag30PercentOff
  • Tag25PercentOff

PR Checklist

Testing Instructions

Go to the Monolith PR and follow instructions there.

  • note: the 30% illustration will be used in FLOW-1044

Don't make me tap the sign.

PR Links and Envs

Repository PR Link PR Env
Monolith Monolith PR Monolith Env
Portal Portal PR N/A

@zippyzow zippyzow changed the title (feat)Discount tag illustrations feat(Illustration) Discount tag illustrations Jan 30, 2025
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jan 30, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit fdf5b8e.

☁️ Nx Cloud last updated this comment at 2025-01-31 15:29:59 UTC

@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://679cec448acf8d00ae38918b--gamut-preview.netlify.app

Deploy Logs

@zippyzow zippyzow changed the title feat(Illustration) Discount tag illustrations feat(Illustration): Discount tag illustrations Jan 31, 2025
@zippyzow zippyzow marked this pull request as ready for review January 31, 2025 18:18
@zippyzow zippyzow requested a review from a team as a code owner January 31, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcenglish jcenglish jcenglish approved these changes

@jakemhiller jakemhiller Awaiting requested review from jakemhiller jakemhiller is a code owner automatically assigned from Codecademy/gamut

@BandanaKM BandanaKM Awaiting requested review from BandanaKM BandanaKM is a code owner automatically assigned from Codecademy/gamut

@xendke xendke Awaiting requested review from xendke

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zippyzow @codecademydev @jcenglish