Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adapt for sub-api keys [ref Codeinwp/optimole-service#1136] #864

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

abaicus
Copy link
Contributor

@abaicus abaicus commented Dec 13, 2024

All Submissions:

Changes proposed in this Pull Request:

  • Changes to adapt this with the sub-api keys integration from the optimole dashboard here https://github.com/Codeinwp/optimole-service/pull/1300
  • If a sub-api key is used, it automatically hides the site selector option under Cloud Library
  • The banner toggle will not work either, as that option is restricted on the dashboard to the root API key.

Closes Codeinwp/optimole-service#1136.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@pirate-bot
Copy link
Collaborator

Plugin build for 0266467 is ready 🛎️!

@abaicus abaicus changed the title [TBD] feat: adapt for sub-api keys [ref Codeinwp/optimole-service#1136] feat: adapt for sub-api keys [ref Codeinwp/optimole-service#1136] Dec 17, 2024
@abaicus abaicus merged commit 9ad0a81 into development Feb 21, 2025
11 of 12 checks passed
@abaicus abaicus deleted the feat/sub-api-keys branch February 21, 2025 14:01
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 3.14.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants