Update the JS pipeline #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
preda-bogdan
suggested changes
Dec 5, 2023
preda-bogdan
approved these changes
Dec 7, 2023
GrigoreMihai
approved these changes
Dec 7, 2023
|
@Soare-Robert-Daniel Tested the PR and didn't find any issue 🚀 |
|
🎉 This PR is included in version 9.0.22 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
pirate-bot
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlights
🚀 Babel is on the latest version, modern features like
boo ?? fooandboo?.namecan be used.👮♂️ Eslint is on the latest version, and new warnings are now available to enforce best practices.
🔧 Format command has been added via Eslint
--fix.🔧 New Github job added to check for lining and dev build posting.
🔥 DevTools now available via
inline-source-map🔥 Webpack is on the latest version.
🖌️ SCSS lang now available
🔥 E2E Testing with Playwright for Free Version
Breakdown
The current state of the JS packages is unacceptable, especially the Babel version, which was very old, and many JS features needed to have the required support.
Upgrading the Babel version was a straight process; we removed some old packages and added new ones like
core-js, which can provide polyfills for old browsers if needed.Vue was updated to its latest version of supported
2.X. Related packages likevuexandvue-loaderwere also updated to the version that still supportsVue 2.X-- in the future, it is recommended to migrate to Vue 3 and Pina store (since it is a new officially recommended store). SASS lang can now be used.After much refactoring to Webpack, the new version of Webpack has excellent features like
--mode, which can easily control the build flow without the need for an env and additional lib likecross-env.Also, the build result is now simplified. The old one created two types of files
build.jsandbuild.min.js, which were coordinated by a PHP var namedROP_DEBUG. Now, onlybuild.jsis created and loaded, and its content is determined by Webpack--mode.ℹ️ On the published version of ROP on WordPress, you will see that both
build.jsandbuild.min.jswere uploaded. Also, the build files were submitted via Git -- now theassets/js/buildis excluded via.gitignoreand the deploy job has been updated to run annpm run buildbefore uploading the the version to WordPress.DevTools are now in full force,
inline-source-mapis now available. Fixing bugs should now be a lot more easier.The E2E setup is similar to the one from Gutenberg which allows us to use their utility function to deal with WordPress internals.
Testing
This is a pretty big update and we need to make sure that we did not introduce any regression. Please check each feature in the interface to ensure the components works as expected.