-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add X limit handling and Logs Export button #903
Conversation
@Soare-Robert-Daniel Tested and here is what i found:
You can check on my instance:
|
Because the app was created with the testing account.
Since the stagging website used the same credentials from the testing account, when you regenerated the API keys, the one from stagging became obsolete.
To my knowledge, we do not support those. Only the Consumer Keys. Also, the reason you saw the error about services was pretty tricky to debug. When you remove via a single action (the delete option that appears when making the account inactive), we do not remove all the data tied to that account. A function did not have a proper checking for it and gave the error. Regarding the inactive state, I see that in the code it is done on purpose here: tweet-old-post/includes/admin/services/class-rop-twitter-service.php Lines 311 to 313 in 1b67a0b
|
@Soare-Robert-Daniel Had another look and there is only one issue left:
|
When uploading the images, the API is set to 1.1 which tweets do not support it.
@irinelenache, now it should work. Also, I updated the staging server to use the same credentials as the normal app. If you try to post with the You will get something like this: ℹ️ If you test it when the quota reset, you might not see it. |
@Soare-Robert-Daniel Checked again and everything's fine now 🚀 |
🎉 This PR is included in version 9.0.23 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
Changelog:
plugin_version
for Twitter/X sign URL to pass the authorization process.Sharing As Image Post
will be available only for users who use their API key. The logic for uploading the images to X/Twitter will not be ported to the server. We should update this article to include the informationNote
Make sure to read https://github.com/Codeinwp/rop-auth-service/pull/78 to get the full picture of the change.
Screenshots
Before
After
Testing
Things to look for:
Sharing As Image Post
will be available only for users who use their API key (Use My Own Keys
)Sign In
option, you should not have any official X/Twitter credentials registered by the plugin in your account profile. You can check this by inspecting the network request, as in the image below. You should have only therop_auth_token
, but if you use the optionUse My Own Keys
, then you should see values with the prefixoauth_
instead ofrop_auth_token
Caution
If you find an issue regarding the authentication values, please send the values in private.
Another thing to test: use the current version of RoP from WP.org, introduce your Twitter API via Sign In, then switch to the build from this PR. With this procedure, you will be connect to the current version of server (not the new one mentioned in above descriptions).
Try to share a post, you will receive an error about time limit reached, when you try again, you will get a message about when the time limit reset: