Ensure that interactive transitions are never 100% completed

With is a workaround for #4
ColinEberhardt · Oct 1, 2013 · fa17dfe · fa17dfe
1 parent d253354
commit fa17dfe
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/InteractionControllers/CEHorizontalSwipeInteractionController.m b/InteractionControllers/CEHorizontalSwipeInteractionController.m
@@ -80,6 +80,13 @@ - (void)handleGesture:(UIPanGestureRecognizer*)gestureRecognizer {
                 fraction = fminf(fmaxf(fraction, 0.0), 1.0);
                 _shouldCompleteTransition = (fraction > 0.5);
 
+                // if an interactive transitions is 100% completed via the user interaction, for some reason
+                // the animation completion block is not called, and hence the transition is not completed.
+                // This glorious hack makes sure that this doesn't happen.
+                // see: https://github.com/ColinEberhardt/VCTransitionsLibrary/issues/4
+                if (fraction >= 1.0)
+                    fraction = 0.99;
+
                 [self updateInteractiveTransition:fraction];
             }
             break;

diff --git a/InteractionControllers/CEVerticalSwipeInteractionController.m b/InteractionControllers/CEVerticalSwipeInteractionController.m
@@ -72,6 +72,13 @@ - (void)handleGesture:(UIPanGestureRecognizer*)gestureRecognizer {
                 fraction = fminf(fmaxf(fraction, 0.0), 1.0);
                 _shouldCompleteTransition = (fraction > 0.5);
 
+                // if an interactive transitions is 100% completed via the user interaction, for some reason
+                // the animation completion block is not called, and hence the transition is not completed.
+                // This glorious hack makes sure that this doesn't happen.
+                // see: https://github.com/ColinEberhardt/VCTransitionsLibrary/issues/4
+                if (fraction >= 1.0)
+                    fraction = 0.99;
+
                 [self updateInteractiveTransition:fraction];
             }
             break;