Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App hangs if the animation is completed manually with interaction controller enabled. #4

Open
devangmundhra opened this issue Sep 30, 2013 · 3 comments

Comments

@devangmundhra
Copy link
Contributor

Hi,

Great library.
Observed an issue with the implementation. The issue is that if an interaction controller and animation controller are both set, and if a transition animation is completed fully by hand after that, the app just hangs.

Reproduction of the bug (Occurs with NavigationController example as well)-

  1. In the settings page, choose "Flip" animation type and "Horizontal Swipe" for the "Settings" section
  2. Press "Done" (Flip animation observed)
  3. Press Settings again (Flip animation observed again)
  4. Starting on the right side of the screen, pan to the left side until the "MyView" page is completely visible (so that leaving the mouse/lifting the finger from the touch) does not do any more animation.
  5. Now the app hangs.

The problem seems to be that for the animation controller, while the - (void)animateTransition:(id<UIViewControllerContextTransitioning>)transitionContext is called at the beginning of the interaction, since the animation is completed fully manually, the completeTransition method is not called from the [UIView animateKeyframesWithDuration.. ]'s completion handler.

@ColinEberhardt
Copy link
Owner

Thanks very much for the detailed bug report. I'll try to reproduce and resolve this issue. :-)

ColinEberhardt added a commit that referenced this issue Oct 1, 2013
@ColinEberhardt
Copy link
Owner

I haven't managed to get to the bottom of this, but have committed a workaround.

@devangmundhra
Copy link
Contributor Author

Awesome.. thanks Colin!

On Tue, Oct 1, 2013 at 2:17 PM, ColinEberhardt [email protected]:

I haven't managed to get to the bottom of this, but have committed a
workaround.


Reply to this email directly or view it on GitHubhttps://github.com//issues/4#issuecomment-25490631
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants