This repository has been archived by the owner on Oct 23, 2021. It is now read-only.
Add support for Apple M1 as development platform. #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…port development on Apple M1
timstokman
reviewed
Jul 24, 2021
Frontend/Dockerfile
Outdated
| RUN apt-get update && apt-get install -y yarn | ||
| #RUN curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | apt-key add - | ||
| #RUN echo "deb https://dl.yarnpkg.com/debian/ stable main" > /etc/apt/sources.list.d/yarn.list | ||
| #RUN apt-get update && apt-get install -y yarn |
There was a problem hiding this comment.
Don't comment out code. If it's no longer needed, delete it.
There was a problem hiding this comment.
I removed it. Sorry about that, I forgot to remove those lines while I was trying to get everything working.
…eam/CollAction into maintenance/frontend
timstokman
approved these changes
Jul 24, 2021
gillesmag
added a commit
that referenced
this pull request
Jul 25, 2021
* Update backend base container images and frontend dependencies to support development on Apple M1 * Update remaining dependencies (except Stripe API) * Upgrade backend * Remove useless comment in Dockerfile * Update test job to latest docker as well * Upgrade mailchimp (no longer suited for DI) * Specify build node version for Netlify Co-authored-by: Gilles Magalhaes <[email protected]> Co-authored-by: Tim Stokman <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, running
docker-compose up -d --builddoes not work as the base images used for the backend as well as the required frontend dependencies are too outdated to support development on an Apple M1-based computer.This pull request contains the necessary changes to allow running all containers required to run the application.
In addition, the frontend dependencies are all updated to their latest version except for the Stripe API (see #401).