Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: put back .html in URLs #243

Merged
merged 3 commits into from
Jan 20, 2024
Merged

DOC: put back .html in URLs #243

merged 3 commits into from
Jan 20, 2024

Conversation

redeboer
Copy link
Member

Reverts #242

GitHub Pages already supports URLs without .html. Since #242, it does not and what is worse is that URLs always get / appended. For websites hosted GitHub Pages, ComPWA/policy#158 (comment) is therefore probably not a good solution.

@redeboer redeboer added 📝 Docs Improvements or additions to documentation ⚠️ Interface Breaking changes to the API labels Jan 20, 2024
@redeboer redeboer self-assigned this Jan 20, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@redeboer redeboer marked this pull request as ready for review January 20, 2024 20:01
@redeboer redeboer enabled auto-merge (squash) January 20, 2024 20:01
@redeboer redeboer merged commit dcb36cd into main Jan 20, 2024
11 checks passed
@redeboer redeboer deleted the revert-242-dirhtml branch January 20, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📝 Docs Improvements or additions to documentation ⚠️ Interface Breaking changes to the API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant