Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: add TR-028 with PDG Python API example #271

Merged
merged 5 commits into from
May 6, 2024
Merged

DOC: add TR-028 with PDG Python API example #271

merged 5 commits into from
May 6, 2024

Conversation

redeboer
Copy link
Member

@redeboer redeboer commented Apr 27, 2024 •
edited
Loading

Added TR-028 [preview], which shows how to work with decay descriptions of the pdg package. See also ComPWA/pdg-api#2.

@redeboer redeboer added the 📝 Docs Improvements or additions to documentation label Apr 27, 2024
@redeboer redeboer added this to the 0.0.2 milestone Apr 27, 2024
@redeboer redeboer requested a review from shenvitor April 27, 2024 14:36
@redeboer redeboer self-assigned this Apr 27, 2024
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@redeboer redeboer enabled auto-merge (squash) April 29, 2024 12:43
shenvitor
shenvitor requested changes Apr 30, 2024
View reviewed changes
Copy link
Member

@shenvitor shenvitor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amigo... Maybe seeing if $J/ \psi -> \pi^0 \pi^0 \pi^0$ should also be there or not?

@redeboer
Copy link
Member Author

Added a warning about the structure of the description string. It's hard to extract particles from that, so that's the reason it doesn't find all decays. The report shows why, so for now I think that should suffice. I don't see how to address this without fixes upstream in the PDG databases.

@redeboer redeboer requested a review from shenvitor April 30, 2024 12:24
@redeboer
Copy link
Member Author

See also ComPWA/pdg-api#2

@redeboer
Copy link
Member Author

So can this be merged (accept PR)?

shenvitor and others added 3 commits May 6, 2024 18:03
redeboer
redeboer commented May 6, 2024
View reviewed changes
docs/report/028.ipynb Outdated Show resolved Hide resolved
shenvitor
shenvitor approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@shenvitor shenvitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

@redeboer redeboer merged commit 510c6f6 into ComPWA:main May 6, 2024
11 checks passed
@redeboer redeboer deleted the pdg-api-investigation branch May 6, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shenvitor shenvitor shenvitor approved these changes

Assignees

@shenvitor shenvitor

@redeboer redeboer

Labels
📝 Docs Improvements or additions to documentation
Projects
None yet
Milestone
0.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@redeboer @shenvitor