Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: install latest Julia version #275

Merged
merged 14 commits into from
May 10, 2024
Merged

Conversation

redeboer
Copy link
Member

@redeboer redeboer commented May 9, 2024

  • The latest version of julia was not installed because Conda's defaults channel installs an older version. To fix this, defaults has been removed from the Conda channels.
  • Julia instructions have been updated to use v1.10.3
  • Manifest.toml has been updated.
  • On RTD, the exact same Julia version is installed as listed in Manifest.toml.

@redeboer redeboer added the 🖱️ DX Improvements to the Developer Experience label May 9, 2024
@redeboer redeboer self-assigned this May 9, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@redeboer redeboer force-pushed the conda-forge branch 16 times, most recently from 62735ec to f655ff6 Compare May 9, 2024 13:58
@redeboer redeboer force-pushed the conda-forge branch 12 times, most recently from a309202 to 001820c Compare May 9, 2024 14:25
@redeboer redeboer changed the title FIX: remove conda default channel FIX: install latest Julia version May 9, 2024
@redeboer redeboer marked this pull request as ready for review May 9, 2024 14:48
@redeboer redeboer requested a review from shenvitor May 9, 2024 14:48
@redeboer redeboer enabled auto-merge (squash) May 10, 2024 12:06
@shenvitor shenvitor closed this May 10, 2024
auto-merge was automatically disabled May 10, 2024 12:06

Pull request was closed

@shenvitor shenvitor reopened this May 10, 2024
@shenvitor shenvitor enabled auto-merge (squash) May 10, 2024 12:07
@shenvitor shenvitor disabled auto-merge May 10, 2024 12:07
Copy link
Member

@shenvitor shenvitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Worked. Approved!

@redeboer redeboer enabled auto-merge (squash) May 10, 2024 12:09
@redeboer redeboer merged commit fd266e4 into ComPWA:main May 10, 2024
21 checks passed
@redeboer redeboer deleted the conda-forge branch May 10, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖱️ DX Improvements to the Developer Experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants