Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: dependency of TR-000 & 001 #276

Merged
merged 3 commits into from
May 10, 2024
Merged

Conversation

shenvitor
Copy link
Member

Closes #272

@shenvitor shenvitor added 🐛 Bug Something isn't working 📝 Docs Improvements or additions to documentation labels May 10, 2024
@shenvitor shenvitor requested a review from redeboer May 10, 2024 12:37
@shenvitor shenvitor self-assigned this May 10, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@shenvitor shenvitor changed the title Fix dependency 000 001 report FIX: dependency 000 001 report May 10, 2024
@shenvitor shenvitor changed the title FIX: dependency 000 001 report FIX: dependency of 000 & 001 report May 10, 2024
@shenvitor shenvitor changed the title FIX: dependency of 000 & 001 report FIX: dependency of TR-000 & 001 May 10, 2024
@shenvitor shenvitor enabled auto-merge (squash) May 10, 2024 12:39
Copy link
Member

@redeboer redeboer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@@ -46,7 +46,7 @@
},
"outputs": [],
"source": [
"%pip install -q black==21.5b2 jax==0.4.28 jaxlib==0.4.28 matplotlib==3.4.2 numpy==1.22 sympy==1.8"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note on pip: numpy==1.22 installs numpy==1.22.0, not the latest patch of v1.22 (in this case numpy==1.22.4). If you want to find the latest version of that patch, use either

pip install -U 'numpy==1.22.*'

or

pip install -U 'numpy~=1.22'

As you noted (#272 (comment)), you can find more info about that here https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts.

In this commit, I upgraded even further to the latest version of NumPy v1 because I got some dependency conflict during runtime (!) with matplotlib.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good that you notice!

@shenvitor shenvitor merged commit 1ab213a into ComPWA:main May 10, 2024
11 checks passed
@shenvitor shenvitor deleted the fix-dependence branch May 10, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working 📝 Docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency issue
2 participants