Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: add Blatt–Weisskopf with Hankel report #277

Merged
merged 9 commits into from
May 16, 2024
Merged

DOC: add Blatt–Weisskopf with Hankel report #277

merged 9 commits into from
May 16, 2024

Conversation

redeboer
Copy link
Member

@redeboer redeboer commented May 15, 2024 •
edited
Loading

Implementation proposal for ComPWA/ampform#417.

Tip

See preview of TR-029 here.

@redeboer redeboer added the 📝 Docs Improvements or additions to documentation label May 15, 2024
@redeboer redeboer self-assigned this May 15, 2024
@ComPWA ComPWA deleted a comment from review-notebook-app bot May 15, 2024
@redeboer redeboer requested a review from mmikhasenko May 15, 2024 12:50
@redeboer redeboer marked this pull request as ready for review May 15, 2024 12:50
@mmikhasenko
Copy link
Contributor

Very good job.
I suggest adding a citation to the original paper by Hippel and Quigg

The paper suggest using them as FF, and list a few lower polynomials,
image

Maybe worth mentioning difference of small h and big H.
https://mathworld.wolfram.com/SphericalHankelFunctionoftheFirstKind.html

@redeboer
Copy link
Member Author

Thanks a lot, also for the difference between spherical and 'general' Hankel functions!
Von Hippel and Quigg were cited, but now more clearly :)

@redeboer redeboer requested a review from shenvitor May 15, 2024 21:45
@redeboer redeboer mentioned this pull request May 16, 2024
Merged
shenvitor
shenvitor approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@shenvitor shenvitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 🚀

@redeboer redeboer enabled auto-merge (squash) May 16, 2024 15:36
@redeboer redeboer merged commit 49ba799 into main May 16, 2024
11 checks passed
@redeboer redeboer deleted the hankel1 branch May 16, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shenvitor shenvitor shenvitor approved these changes

@mmikhasenko mmikhasenko Awaiting requested review from mmikhasenko

Assignees

@redeboer redeboer

Labels
📝 Docs Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@redeboer @mmikhasenko @shenvitor